Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing using official postgresql docker images #70

Open
madalinignisca opened this issue Nov 24, 2023 · 3 comments
Open

Testing using official postgresql docker images #70

madalinignisca opened this issue Nov 24, 2023 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@madalinignisca
Copy link

Hi. I would have posted this as a discussion, not an issue.

I was confused to see the tests running against ankane/pgvector and not a matrix of all current supported Postgresql versions using the official images.

Any reasons why ankane/pgvector is better than postgresql image and making tests running like Laravel and PHP versions mixed with them?

@tpetry
Copy link
Owner

tpetry commented Nov 25, 2023

I recently introduced support for pg_vector so the image to run against needs to have that extension as well. And the prebuilt docker containers simply don't support the vast range of supported PG versions. I have to build custom docker images as service customers at some point but I didn't have the time yet to research how this works with Github Actions.

@tpetry tpetry added the help wanted Extra attention is needed label Nov 25, 2023
@madalinignisca
Copy link
Author

I recently introduced support for pg_vector so the image to run against needs to have that extension as well. And the prebuilt docker containers simply don't support the vast range of supported PG versions. I have to build custom docker images as service customers at some point but I didn't have the time yet to research how this works with Github Actions.

The official postgresql images are based on the official debian apt repositories from postgresql.org.

If you give me a list of required extensions and anything to run after to enable them, I can prepare a scheduled action that builds them on top of the official images and puts them public on Docker Hub. Once done, it will need very low maintenance.

The postgis/postgis image is done that way, except it doesn't yet support arm64.

With same idea, if tests should be done over a matrix of versions combinations, multiple images could be done this way to support that.

@tpetry
Copy link
Owner

tpetry commented Dec 4, 2023

That's a step I wanted to omit. Like building images and putting them on DockerHub or GitHub Docker registry.

I prefer creating the needed images within the CI workflow so it is easier to manage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants