Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PyTorchFileRecorder enum deserializer error message #2663

Open
laggui opened this issue Jan 6, 2025 · 0 comments
Open

Improve PyTorchFileRecorder enum deserializer error message #2663

laggui opened this issue Jan 6, 2025 · 0 comments
Labels
enhancement Enhance existing features

Comments

@laggui
Copy link
Member

laggui commented Jan 6, 2025

Trying to import a pytorch model into its corresponding Burn implementation can be a little difficult for new users, especially if the definition involves multiple enum modules to match the pytorch structure.

If the definition is not exact on the first attempt, which usually involves remapping some keys, it usually leads to an error like:

Failed to load model: DeserializeError("Serde error: failed to deserialize: No variant match for LayerTypeRecordItem")

This is not very helpful. We should try to provide a more helpful error message.

Ref: discord convo

@laggui laggui added the enhancement Enhance existing features label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing features
Projects
None yet
Development

No branches or pull requests

1 participant