Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send SOL #4525

Open
Hannsek opened this issue Jan 23, 2025 · 4 comments
Open

Send SOL #4525

Hannsek opened this issue Jan 23, 2025 · 4 comments
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1.

Comments

@Hannsek
Copy link
Contributor

Hannsek commented Jan 23, 2025

Design:
TS5: Figma

Image

TS3: Figma

Image

TT: Figma

Image

@Hannsek Hannsek added the core Trezor Core firmware. Runs on Trezor Model T and T2B1. label Jan 23, 2025
@gabrielKerekes
Copy link
Contributor

Thanks for this. I have a couple of clarifying questions:

Question 1: in case all the instructions in a transaction are known and no instruction creates an account we'd display just "Fee" instead of "Max fees and rents" and also "Max rent fee" would of course be left out from the "Fee Information" screen, right?

If there's instructions which create accounts or unknown instructions (which might create accounts) we display the UI proposed in this issue.

Question 2: Currently in the final tx confirmation screen under the "i" button we displays the account and blockhash. This would be dropped in favor of fee information?

Question 3:
The menu UI for TS5 is already available in the code? (I have never worked with TS5 yet, so I'm not sure if the menu is already there or if it's something that you need to add yet).

@matejcik
Copy link
Contributor

Question 1: in case all the instructions in a transaction are known and no instruction creates an account we'd display just "Fee" instead of "Max fees and rents" and also "Max rent fee" would of course be left out from the "Fee Information" screen, right?

yes

or unknown instructions

I'd make that UI even more different (cc @Hannsek), perhaps show "fees and rents: unknown" or sth

Question 2: Currently in the final tx confirmation screen under the "i" button we displays the account and blockhash. This would be dropped in favor of fee information?

clarifying this internally.
we have a mechanism for showing two menu items, "account info" and "some other info" (don't remember the copy), so we'd use that here too. we would still keep the same information and add the fees to it.

Question 3:
The menu UI for TS5 is already available in the code?

look at what Ethereum does and copy it

@Hannsek
Copy link
Contributor Author

Hannsek commented Jan 24, 2025

Question 1: in case all the instructions in a transaction are known and no instruction creates an account we'd display just "Fee" instead of "Max fees and rents" and also "Max rent fee" would of course be left out from the "Fee Information" screen, right?

yes, also please use "Transaction fee" if it would be standard transaction without rents

or unknown instructions

I'd make that UI even more different (cc @Hannsek), perhaps show "fees and rents: unknown" or sth

Seems fine, let's put there

Max Fees and rents: 
Unknown

Question 2: Currently in the final tx confirmation screen under the "i" button we displays the account and blockhash. This would be dropped in favor of fee information?

Working on updated designs, thanks for the catch.

@matejcik
Copy link
Contributor

look at what Ethereum does and copy it

there's an internal UI function confirm_summary or _confirm_summary that has the right arguments that you need. use that in confirm_solana_tx, we're still doing some refactors around it so we'll take it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Projects
Status: No status
Development

No branches or pull requests

3 participants