Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoPTR should throw an error on invalid parameter choices #10

Open
brendanwee opened this issue Sep 14, 2021 · 2 comments
Open

CoPTR should throw an error on invalid parameter choices #10

brendanwee opened this issue Sep 14, 2021 · 2 comments

Comments

@brendanwee
Copy link

brendanwee commented Sep 14, 2021

I ran an experiment trying min-cov to be .3, .4, .5, .6 and .75 on 10 datasets. Each data set had the same exact result for each value of min-cov.

Also just a small nitpick: the --min-cov parameter should error out or complain if the user provides an argument greater than one.

@brendanwee brendanwee changed the title --min-cov should be restricted to less than one --min-cov does not seem to work Sep 15, 2021
@brendanwee
Copy link
Author

Closing this because I think I just have some questions around how to run this tool.

@tyjo
Copy link
Owner

tyjo commented Sep 15, 2021

The --min-cov flag gives the proportion of the genome that to be covered by at least 1 read. This is more for quality filtering to remove genomes with many reads that mapped to a conserved region, but may not be present in the sample.

I'm going to reopen this issue because I agree with your nitpick. Invalid parameter combinations should throw an error.

@tyjo tyjo reopened this Sep 15, 2021
@tyjo tyjo changed the title --min-cov does not seem to work CoPTR should throw an error on invalid parameter choices Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants