Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prePR command—or another solution to fatal-warnings-in-CI #15

Closed
armanbilge opened this issue Dec 30, 2021 · 1 comment · Fixed by #70
Closed

prePR command—or another solution to fatal-warnings-in-CI #15

armanbilge opened this issue Dec 30, 2021 · 1 comment · Fixed by #70

Comments

@armanbilge
Copy link
Member

armanbilge commented Dec 30, 2021

Spinning out of #12 (comment).

The underlying problem is we often want fatal warnings in CI, but not locally since it makes development/experimentation annoying. But then, we end up fighting CI :)

One proposal is we add a prePR command that emulates a CI compile, by cleaning and enabling fatal warnings (if that is indeed how CI is configured).

@armanbilge
Copy link
Member Author

Ooh, another good one for prePR is to check the workflow is up-to-date. I just mucked that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant