You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why do you use the main key calib? Will there be any other key? My suggestion is to drop it and just use a sequence.
The sensor_name is not used yet. Do we need it at all? Is that just for documentation?
As far as I understand, single_calib_ is used for all taxels if:
there is no multi-calib given at all
there is no idx_range given for any sequence item
there is a single, negative idx specified in idx_range for any sequence item
I suggest to drop this last condition or replace it by idx_range: default.
My key suggestion is to use this as the default (or fallback) calib, if nothing more specific was defined for a taxel. Currently, single_calib_ is only actually used when calib_ is empty and calib_ is only used if it defines calibs for all taxel inputs.
If we agree on this new semantics, I would cleanup the code some more towards this direction.
Hence, an example yaml config would look like this:
calib
? Will there be any other key? My suggestion is to drop it and just use a sequence.sensor_name
is not used yet. Do we need it at all? Is that just for documentation?single_calib_
is used for all taxels if:idx_range
given for any sequence itemnegative
idx specified inidx_range
for any sequence itemI suggest to drop this last condition or replace it by
idx_range: default
.My key suggestion is to use this as the default (or fallback) calib, if nothing more specific was defined for a taxel. Currently,
single_calib_
is only actually used whencalib_
is empty and calib_ is only used if it defines calibs for all taxel inputs.If we agree on this new semantics, I would cleanup the code some more towards this direction.
Hence, an example yaml config would look like this:
Handle, both C++ and python parser and dumper.
The text was updated successfully, but these errors were encountered: