Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy interp function has been removed as of v1.12 #43

Open
mooreryan opened this issue Dec 5, 2024 · 2 comments
Open

scipy interp function has been removed as of v1.12 #43

mooreryan opened this issue Dec 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mooreryan
Copy link
Collaborator

(I think that's the version it was removed at least.)

In Submodule 4, Tutorial 1, the ROC curve section uses interp from scikit learn. This has been removed in recent scipy versions, so we need to replace it with something else.

There is numpy.interp, which may be a direct replacement. (What do you think @chenchuming ?)

There is also interp1d from scipy.interpolate. It definitely has a different interface, but maybe it is doing what you want Chuming.

Potentially something like this:

from scipy.interpolate import interp1d
# ...
interpolation = interp1d(fpr[i], tpr[i])
mean_tpr += interpolation(all_fpr)
@mooreryan mooreryan added the bug Something isn't working label Dec 5, 2024
@chenchuming
Copy link
Contributor

It looks good to me.

@mooreryan
Copy link
Collaborator Author

Since we're likely going with the conda set up, I can do like I did in #46 and figure out which version of sklearn to use so that we don't have to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants