Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Suggestions for current song #13

Open
udiboy1209 opened this issue Nov 11, 2017 · 2 comments
Open

Display Suggestions for current song #13

udiboy1209 opened this issue Nov 11, 2017 · 2 comments
Labels

Comments

@udiboy1209
Copy link
Owner

Youtube gives a list of video suggestions for current playing video. Need to figure out a good way to display it on the screen, so that it doesn't interfere with the video player and list.

Backend functions already exist to fetch a list, front-end part remains.

@Jigar3
Copy link
Contributor

Jigar3 commented Nov 23, 2017

Can you guide me how to tackle this issue

@udiboy1209
Copy link
Owner Author

Check this function to fetch suggested videos.
You may want to create a new module suggestions.js for this.

For displaying, it is similar to the <ul> used for playlist and searchlist.
I'll leave it on you to figure out exactly how it should be displayed. Think about user-experience aspects when making choices (how easily is it accessible, does it cover important parts of the screen, should it auto-hide, when should it show etc.)

The last implementation I had simply showed a list of suggestions for the current playing song next to the playlist. It took up unnecessary screen space and looked weird and confusing, so I removed it when remaking the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants