Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix physical tests #44

Open
BLuedtke opened this issue Dec 5, 2024 · 0 comments · May be fixed by #45
Open

Fix physical tests #44

BLuedtke opened this issue Dec 5, 2024 · 0 comments · May be fixed by #45
Assignees

Comments

@BLuedtke
Copy link
Collaborator

BLuedtke commented Dec 5, 2024

The physical tests have some known issues and room for improvement.

  • the point state is not recorded correctly: the point is switched and immediately afterwards its state is sampled. At that point, we haven't had time to receive the feedback from the corresponding control board on the execution state of the point.
  • memory is not always freed correctly.
  • tests with train driving: after we set the points, we don't check if they are in the expected position -> if a point is not working correctly, we'll likely get a short circuit.
  • we could use some more documentation and perhaps debugging info, for example the track output and booster state when the SIGINT callback is triggered, i.e., if we manually abort a test.

Work on this has already begun in branch fix-physical-test.

@BLuedtke BLuedtke self-assigned this Dec 5, 2024
@BLuedtke BLuedtke linked a pull request Dec 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant