Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma correction is missing #29

Open
sschoenborn opened this issue Mar 30, 2017 · 0 comments
Open

Gamma correction is missing #29

sschoenborn opened this issue Mar 30, 2017 · 0 comments

Comments

@sschoenborn
Copy link
Contributor

The framework does not apply gamma correction. Rendering and illumination inversion is thus not optimal - it assumes a linear colorspace while we do everything in sRGB right now. However, we should wait for an easy-to-use and consistent solution to really approach this issue. Until then, people who really need this usually know how to approach the problem and can fix it where issues occur :) (a gamma conversion function is available in GammaCorrection.toLinear and GammaCorrection.toGamma)

Be warned about missing gamma correction - we currently use sRGB values everywhere! This matters for

  • physical rendering
  • shadow corrections
  • image manipulation (additions)
  • illumination inversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant