Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup yamllint and local render #7

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jan 4, 2024

Description of your changes

  • config
  • make target
  • github action
  • render target

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

make render
crossplane beta render examples/flux-xr.yaml apis/composition.yaml examples/functions.yaml -r
---
apiVersion: gitops.platform.upbound.io/v1alpha1
kind: XFlux
metadata:
  name: configuration-gitops-flux
---
apiVersion: helm.crossplane.io/v1beta1
kind: Release
...

Before the yaml fixes

make yamllint
17:12:51 [ .. ] running yamllint
./apis/definition.yaml
  104:96    error    trailing spaces  (trailing-spaces)

17:12:51 [FAIL]
make: *** [Makefile:74: yamllint] Error 1
image

* config
* make target
* github action
* render target

Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
@ytsarev
Copy link
Member Author

ytsarev commented Jan 4, 2024

/test-examples

@ytsarev ytsarev requested a review from a team January 4, 2024 16:16
@ytsarev ytsarev merged commit 84d9e52 into upbound:main Jan 4, 2024
2 checks passed
@ytsarev ytsarev deleted the yamllint branch January 4, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants