Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(caas): backport from caas #42

Closed
wants to merge 2 commits into from
Closed

feat(caas): backport from caas #42

wants to merge 2 commits into from

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Oct 16, 2023 •
edited
Loading

Description of your changes

  • backport from caas
  • update
    • XAKS
      • add region as input
      • add providerConfig as input
    • XCluster
      • add region as input
      • add providerConfig as input
      • using patchSets
    • XNetwork
    • XService
      • add flux
      • use prometheus as default
  • rename folder package -> apis
  • enable usages for XAKS, XServices and XApp
  • switch crossplane.yaml to root folder
  • update Makefile
  • bump submodule

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

uptest

@haarchri haarchri force-pushed the feature/backport-caas branch from 8c7d87a to 0c65232 Compare October 16, 2023 20:37
@haarchri
Copy link
Member Author

/test-examples

ytsarev
ytsarev reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the initial feedback

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
crossplane.yaml Show resolved Hide resolved
@haarchri
feat(caas): backport from caas
df2b595 
Signed-off-by: Christopher Haar <[email protected]>
@haarchri haarchri force-pushed the feature/backport-caas branch from 458adc9 to df2b595 Compare October 17, 2023 07:22
@haarchri
Copy link
Member Author

/test-examples

@haarchri
feat(caas): backport from caas
c60f50a 
Signed-off-by: Christopher Haar <[email protected]>
@haarchri haarchri requested a review from ytsarev October 17, 2023 08:55
ytsarev
ytsarev reviewed Oct 17, 2023
View reviewed changes
package/cluster/composition.yaml
Copy link
Member

@ytsarev ytsarev Oct 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make git mv package/cluster/composition.yaml apis/cluster/composition.yaml so the actual diff will be visible? For all the moved files involved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will split this PR for better visibility: first: #43

@haarchri haarchri mentioned this pull request Oct 29, 2023
Merged
3 tasks
@haarchri
Copy link
Member Author

followup via: #44

@haarchri haarchri closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haarchri @ytsarev