Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating testing repo with more examples! #4

Open
vsoch opened this issue Mar 24, 2020 · 4 comments
Open

Updating testing repo with more examples! #4

vsoch opened this issue Mar 24, 2020 · 4 comments

Comments

@vsoch
Copy link
Contributor

vsoch commented Mar 24, 2020

Per discussion in urlstechie/urlchecker-python#11 (comment), @SuperKogito mentioned he is going to put on his queue to add more examples to the testing repo here. Since the issue was separate from the update to the urlchecker-python I am opening it here (and merging the PR there so I can speed up the testing!) Thanks @SuperKogito let me know if I can help here- I think you have a better sense of what you want to add.

@vsoch
Copy link
Contributor Author

vsoch commented Mar 24, 2020

Also I'm not able to assign people / otherwise manage this repository, just a heads up!

@SuperKogito
Copy link
Member

@vsoch I am very sorry but I will only be active again starting next Wednesday. My hands are full atm. I am really sorry to do this as such a crucial time for the tools :( I accepted the reviews, I read the comments but I will answer them next week and the same goes for the release unless if you want to do it. I would rather wait a couple of days than do it in a rush cuz with my current level of stress I would probably do a sloppy job.

I just made you an owner so you can be able to assign people and do it all. Just remember :p

Stay safe, stay healthy ;)

@vsoch
Copy link
Contributor Author

vsoch commented Mar 25, 2020

Love it :)

Don't worry there is no rush on these things! Let's touch bases when you get back / have some time, and I'll watch over the repository in the meantime! 🦇 👨 👩 💪

@vsoch
Copy link
Contributor Author

vsoch commented Apr 21, 2020

Per discussion in urlstechie/urlchecker-python#43 (comment), the link there should take you to a jobs.yml that should be added as a testing file somewhere here. Actually just taking a few lines from it would be sufficient (and not redundant).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants