Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cif2cell breaking conda-forge recipe #163

Open
wd15 opened this issue Apr 26, 2021 · 12 comments
Open

cif2cell breaking conda-forge recipe #163

wd15 opened this issue Apr 26, 2021 · 12 comments

Comments

@wd15
Copy link
Collaborator

wd15 commented Apr 26, 2021

cif2cell is not updated on conda-forge (it's only available for Python 2.7). It is up to date on pip at version 2.0.0a3. However, it's also not possible to pip install to build a conda-forge recipe.

Possible options to fix this are:

  • Don't make cif2cell a strict dependency (make it optional) until it's updated on conda-forge. Good option if it's only a niche usage in Jarvis. Raise an error in jarvis where it's used and say that you need to install with pip install. Try to quarantine it's usage a bit so the import is only in the function where it's used.
  • Contact the authors and ask them to update conda-forge recipe
  • Remove its usage and look for alternatives.
@wd15
Copy link
Collaborator Author

wd15 commented Apr 26, 2021

When I remove cif2cell I get this error. Obviously, Jarvis now requires cif2cell.

@wd15
Copy link
Collaborator Author

wd15 commented Apr 26, 2021

With cif2cell I get this error. cif2cell is very old in conda-forge.

Here is one of the issues:

2021-04-26T14:02:58.0585909Z cif2cell -> python[version='>=2.7,<2.8.0a0']

@wd15
Copy link
Collaborator Author

wd15 commented Apr 26, 2021

@knc6
Copy link
Collaborator

knc6 commented Apr 29, 2021

@wd15 I have removed cif2cell hard-dependency now.

@wd15
Copy link
Collaborator Author

wd15 commented Apr 30, 2021

Great. That merges now so new release should be available soon.

@wd15
Copy link
Collaborator Author

wd15 commented Apr 30, 2021

I installed with conda install -c jarvis-tools and I'm getting version 2020.11.27 for some reason?!?

If I do conda search -f jarvis-tools, I get

Loading channels: done
# Name                       Version           Build  Channel             
jarvis-tools              2020.10.10    pyh9f0ad1d_0  conda-forge         
jarvis-tools              2020.10.20    pyhd8ed1ab_0  conda-forge         
jarvis-tools               2020.11.9    pyhd8ed1ab_0  conda-forge         
jarvis-tools              2020.11.27    pyhd8ed1ab_0  conda-forge         
jarvis-tools              2020.12.31    pyhd8ed1ab_0  conda-forge         
jarvis-tools                2021.2.1    pyhd8ed1ab_0  conda-forge         
jarvis-tools                2021.2.3    pyhd8ed1ab_0  conda-forge         
jarvis-tools               2021.2.21    pyhd8ed1ab_0  conda-forge         
jarvis-tools               2021.2.22    pyhd8ed1ab_0  conda-forge         
jarvis-tools                2021.3.4    pyhd8ed1ab_0  conda-forge         
jarvis-tools               2021.3.11    pyhd8ed1ab_0  conda-forge         
jarvis-tools               2021.3.13    pyhd8ed1ab_0  conda-forge         
jarvis-tools               2021.4.10    pyhd8ed1ab_0  conda-forge         
jarvis-tools               2021.4.18    pyhd8ed1ab_0  conda-forge

Could it be that the version isn't ordering properly. Maybe can you try using a version number of 2021.04.30 for example so always have two digits for the day and year. For, example, if I do the same for pandas then it's nicely ordered. I'll check the settings as well to see if we can change something to get the version ordering correct.

Edit: Sorry, I'm going crazy, it is correctly ordered. Ignore that.

Edit again: I need to figure out why it's not giving me the latest version by default.

@knc6
Copy link
Collaborator

knc6 commented Apr 30, 2021

Yea, in pypi, it seems to work fine: https://pypi.org/project/jarvis-tools/#history

@wd15
Copy link
Collaborator Author

wd15 commented Apr 30, 2021

I've seen this with other packages as well when there's an issue with dependencies and precedence. For example, installing sfepy used to change the environment from Python 3 to 2.

A few stackoverflow links 1, 2.

I'm not sure what to do. I suggest changing the install instructions to say do

$ conda install -c conda-forge jarvis-tools=$(conda search -f jarvis-tools | tail -1 | awk '{print $2}')

but that's gruesome. Maybe just say use conda-forge search -f jarvis-tools to find latest version and then specify the latest version.

Conda is such a pain with the way it resolves packages.

@wd15
Copy link
Collaborator Author

wd15 commented Apr 30, 2021

What happens when you install jarvis-tools. do you get the latest version or same as me?

@knc6
Copy link
Collaborator

knc6 commented Apr 30, 2021

So, I created a new conda environment and ran conda install -c conda-forge jarvis-tools . It does install 2021.4.18 not 2021.4.28 which is weird.

@knc6
Copy link
Collaborator

knc6 commented Apr 30, 2021

Actually I dont see the 2021.4.28 version on the conda search:
conda search -f jarvis-tools -c conda-forge
image

@wd15
Copy link
Collaborator Author

wd15 commented Apr 30, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants