Rename generic fitters to reflect more general usage

[joefowler]

Original report by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

---

We currently use GenericKAlphaFitter and GenericKBeta fitter heavily for non KAlpha and KBeta lines. The functional distinction is that the KAlpha fitter allow dpdE to float, while the KBeta fitter will not. This is because KAlpha lines generally have enough structure that energy resolution and dPdE are not degenerate with our resolution.

‌

Also, we should move towards explicitly defining the generic fitter in the call to addfitter rather than having a few special cases about how to pick the generic fitter.

[joefowler]

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

---

I can’t tell if this is still relevant as of PR #117. I think it is, but do you have further comments?

[joefowler]

Original comment by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

---

I dont think PR #117 solves this. My imagination of a solution would remove the concept of a GenericKAlphaFitter and GenericKBeta fitter and instead have like Model(spectrum, ok_to_float_dp_de) or something like that. Also I’m wondering if doing all calibration in energy space make the point moot… we basically should always have dp_de not vary, and required people to opt into it varying explicitly.

[joefowler]

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

---

Removing milestone: v0.7 (automated comment)