You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I've noticed that inserting an UInt64 with a value bigger than Int.max into a field using FluentMySQL does not work.
This is because FluentMySQL only makes use of the MySQLData init(int:) initializer.
(FluentMySQL also translates UInt64 to INT in sql but this is another issue).
Describe the solution you'd like
As PostgresNIO also includes separate initializers and conversion methods for the different integer types i would suggest to also implement these in mysql-nio.
Separate MySQLDataConvertible-Conformance
-> Instead of one extension for FixedWidthInteger. NumericCast is no longer necessary.
extensionUInt64:MySQLDataConvertible{publicinit?(mysqlData:MySQLData){
guard let int = mysqlData.uint64 else{returnnil}self= int
}publicvarmysqlData:MySQLData?{return.init(uint64:self)}}
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
I've noticed that inserting an UInt64 with a value bigger than Int.max into a field using FluentMySQL does not work.
This is because FluentMySQL only makes use of the MySQLData init(int:) initializer.
(FluentMySQL also translates UInt64 to INT in sql but this is another issue).
Describe the solution you'd like
As PostgresNIO also includes separate initializers and conversion methods for the different integer types i would suggest to also implement these in mysql-nio.
Custom initializers for MySQLData:
Separate MySQLDataConvertible-Conformance
-> Instead of one extension for FixedWidthInteger. NumericCast is no longer necessary.
The text was updated successfully, but these errors were encountered: