Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple Notes per RawContact #343

Open
3 tasks
vestrel00 opened this issue Mar 27, 2024 · 0 comments
Open
3 tasks

Support multiple Notes per RawContact #343

vestrel00 opened this issue Mar 27, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@vestrel00
Copy link
Owner

vestrel00 commented Mar 27, 2024

Problem

As discussed in #342 with @Yameteh, some OEMs such as Oppo and its ColorOS allows a RawContact to have multiple Notes.

The CRUD APIs provided in this library currently only supports one Note per RawContact. Currently,

  • only one Note is read per RawContact even if there are more than one in the Data table
  • performing an update operation on a RawContact with multiple existing Notes may result in unexpected behavior such as update not working or even all Notes being deleted except for one

Note

The behavioral contract that has been upheld by many different OEMs for Notes is that a RawContact only has a single Note. I verified using my own devices that the following OEMs adheres to this implicit contract;

  • Google Pixel
  • Samsung (OneUI)
  • Xiaomi / Redmi (HyperOS)
  • RedMagic (RedMagic OS)
  • Lenovo (ZUI)
  • Apple (iOS)

Solution

Add support for multiple Notes per RawContact.

  1. This must be an opt-in feature / behavioral change.
  2. Do not change the existing API contract of one Note per RawContact.
  3. Create extension functions instead.

This solution requires #344 to be implemented first.

  • Update Kotlin docs
  • Update markdown docs
  • Update gh-pages
@vestrel00 vestrel00 added the enhancement New feature or request label Mar 27, 2024
@vestrel00 vestrel00 self-assigned this Mar 27, 2024
@vestrel00 vestrel00 changed the title Add support for multiple Notes per RawContact Support for multiple Notes per RawContact Mar 27, 2024
@vestrel00 vestrel00 changed the title Support for multiple Notes per RawContact Support multiple Notes per RawContact Mar 27, 2024
@vestrel00 vestrel00 added this to the More awesome features! milestone Mar 27, 2024
@vestrel00 vestrel00 removed this from the More awesome features! milestone Jan 23, 2025
@vestrel00 vestrel00 moved this to Todo in Contacts pre-v1 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant