Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing field for Email entity #360

Open
aartiPl opened this issue Jan 3, 2025 · 3 comments
Open

Missing field for Email entity #360

aartiPl opened this issue Jan 3, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@aartiPl
Copy link

aartiPl commented Jan 3, 2025

Seems that there is missing email label in all the Email entities (at least Email, NewEmail).

Currently definition of Email looks like that:

image

But there is also another field for Email:

image

in ContactsContract.java.

I guess it should be added :-)

@aartiPl
Copy link
Author

aartiPl commented Jan 8, 2025

And looks that NewWebsite is missing Type and Label:
https://developer.android.com/reference/android/provider/ContactsContract.CommonDataKinds.Website

@vestrel00
Copy link
Owner

vestrel00 commented Jan 8, 2025

Hey @aartiPl, thanks for reporting this!

I based my implementation, including these entity definitions, on the behaviors I observed from the AOSP Contacts app and Google Contacts app. I don't remember those fields being used by those aforementioned apps, which is why I think I did not include them.

You are technically correct that these things are missing. I just did not think they would be used or noticed by anyone until you reported this issue 😃

I will look into this when I get the time and will include it in the next release. Work and life are super busy so I have not been able to work on this project for a while 😅

@vestrel00 vestrel00 self-assigned this Jan 8, 2025
@vestrel00 vestrel00 added the enhancement New feature or request label Jan 8, 2025
@aartiPl
Copy link
Author

aartiPl commented Jan 8, 2025

I am working on contact manager like application, so probably I will find such issues time to time :-) Anyway thanks a lot for your hard work - Android contact Api is really tricky!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants