Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make original pageContext accessible to error page #1112

Open
brillout opened this issue Sep 8, 2023 · 2 comments
Open

Make original pageContext accessible to error page #1112

brillout opened this issue Sep 8, 2023 · 2 comments
Labels
enhancement ✨ New feature or request

Comments

@brillout
Copy link
Member

brillout commented Sep 8, 2023

Description

Use case: i18n, see #1110.

In principle, it should be possible to make the original pageContext (of the page that failed to render) available to the error page's pageContext, e.g. at pageContext.pageContextOriginal.

Ideally, it should be automatically merged to the error pageContext so that it "just works", while preserving a pristine pageContext at pageContext.pageContextError.

@brillout brillout added the enhancement ✨ New feature or request label Sep 8, 2023
@fvanwijk
Copy link

Alternatively instead of merging, you could make the original pageContext available on the error's pageContext.originalPageContext.

@brillout
Copy link
Member Author

brillout commented Sep 11, 2023

Actually, in general, I'm thinking the best is to do both: merge everything into pageContext while providing a pageContext.from. See #1268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants