Remove dist/server/ upon $ vike build + pre-rendering

[brillout]

Description

dist/server/ isn't needed for a fully pre-rendered app, and users are often confused about why it's there. We can remove it once we implement Vike's CLI.

It should only be removed if the user doesn't disable build chaining.

Blocker: Vike's CLI.

[JayaKrishnaNamburu]

If prerender is enabled. Should vike also remove dist/assets/entires/entry-server-routing.js or dist/assets/entries/entry-client-routing.js files too. Which are injected in the buildConfig stage here

vike/vike/node/plugin/plugins/buildConfig.ts

Lines 151 to 169 in 962127b

	} else {
	let { hasClientRouting, hasServerRouting, clientEntries } = analyzeClientEntries(pageConfigs, config)
	if (Object.entries(pageFileEntries).length > 0) {
	hasClientRouting = true
	hasServerRouting = true
	}
	const entries: Record<string, string> = {
	...clientEntries,
	...pageFileEntries
	}
	const clientRoutingEntry = resolve(`dist/esm/client/client-routing-runtime/entry.js`)
	const serverRoutingEntry = resolve(`dist/esm/client/server-routing-runtime/entry.js`)
	if (hasClientRouting) {
	entries['entries/entry-client-routing'] = clientRoutingEntry
	}
	if (hasServerRouting) {
	entries['entries/entry-server-routing'] = serverRoutingEntry
	}
	return entries

Or they still needed in terms of serverRouting / clientRouting aspect. And can you help me understand what's the main difference between the both. Because both seem to run inside the browser and wondering what's the difference and if they are really needed.

[brillout]

See https://vike.dev/clientRouting. Indeed, of the two entries can be removed (but not always since clientRouting can differ on page-by-page basis).

[JayaKrishnaNamburu]

But the entry-server-routing.js file can be removed ?
If the prender is set to true and the clientRouting is set to false ?

The JS check seems to inject the server routing file, which is expected as the default behaviour as client routing is disabled. But isn't it redundant to have prerendered and server-routing both ?

[JayaKrishnaNamburu]

@brillout checking again, if the pre-rendering is enabled
https://vike.dev/pre-rendering#how-to-pre-render

is it safe to remove dist/assets/entries/entry-server-routing.js and dist/assets/entry-client-routing.js files ?

[brillout]

Actually, why do you want to remove them in the first place? What's the issue you're trying to solve?

[JayaKrishnaNamburu]

It's actually trying to work with netlify forms. So, ideally pre-rendering should allow them to be detectable. But, the whole netlify form detection behaviour is bit of a black box. So, if we remove routing` files the detection is working. But it the routing files exists, i think its rendering them as client side ones and not able to detect. Might be a bug on the netlify detection side itself, but checking we can remove routing files.

[brillout]

@JayaKrishnaNamburu Can you create a new GitHub discussion and elaborate more? It's unrelated to this issue. I'll reply over there.