Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments like kubelet_args not properly escaped into script templates #400

Open
jrudolph opened this issue Aug 2, 2024 · 1 comment
Open

Comments

@jrudolph
Copy link
Contributor

jrudolph commented Aug 2, 2024

I used a setting like

kubelet_args:
  - "eviction-hard=memory.available<200Mi"

which led to the master init script silently failing. The reason is that the shell interprets the < inside of the command line to set up k3s.

Suggestions for improvements:

  • either document or properly escape values like this when pasting into scripts
  • properly upload script before executing and use set -e to avoid the script running to the end even when steps failed
  • better error reporting when something fails
@vitobotta
Copy link
Owner

Hi, thanks for reporting this. So you just need to wrap the line in double quotes?

Would you have a chance to open a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants