Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission Revocation - English language clarification #361

Open
karlcow opened this issue Sep 26, 2023 · 0 comments
Open

Permission Revocation - English language clarification #361

karlcow opened this issue Sep 26, 2023 · 0 comments

Comments

@karlcow
Copy link
Member

karlcow commented Sep 26, 2023

In the security and privacy considerations, there is this section about revocation. To note that this is the only section of the specification where revocation is explained.

When a permission is revoked, the user agent MAY fire the "pushsubscriptionchange" event for subscriptions created with that permission, with the service worker registration associated with the push subscription as registration, a PushSubscription instance representing the push subscription as oldSubscription, and null as newSubscription. The user agent MUST deactivate the affected subscriptions in parallel.

It has too many with in a row to make it clear (at least for ESL like me).
Would there be a way to rephrase this to make it clear? I put the red dots where it starts to be confusing in the level of English nesting.

When a permission is revoked,

Other mentions of revocation.

Then in 10.5 The pushsubscriptionchange Event

The pushsubscriptionchange event indicates a change in a push subscription that was triggered outside of the application's control, for example because it has been refreshed, revoked or lost.

And in the security and privacy section with

Permissions that are preserved beyond the current browsing session MUST be revocable.

karlcow added a commit to karlcow/push-api that referenced this issue Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants