Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new release of xterm break local-echo #11

Open
mattLLVW opened this issue Sep 23, 2019 · 3 comments
Open

new release of xterm break local-echo #11

mattLLVW opened this issue Sep 23, 2019 · 3 comments

Comments

@mattLLVW
Copy link

Hi,
in the new release of xterm 4.0.0 they removed the deprecated "old" event API, so local-echo no longer works.

Would you accept a PR to fix that?
@wavesoft
Copy link
Owner

Hello @mattLLVW , thanks for pointing this out. Will have a look 👍

janstuemmel pushed a commit to janstuemmel/local-echo that referenced this issue Jan 16, 2020
Fixed compatibility issues with xtermjs 4
5150c05 
xtermjs 4 removed the on() listener method and
replaced it with onData, onResize, ... methods

related wavesoft#11
This was referenced Jan 16, 2020
Closed
Closed
janstuemmel pushed a commit to janstuemmel/local-echo that referenced this issue Jan 17, 2020
Fixed compatibility issues with xtermjs 4
4d99a7e 
xtermjs 4 removed the on() listener method and
replaced it with onData, onResize, ... methods

related wavesoft#11
janstuemmel pushed a commit to janstuemmel/local-echo that referenced this issue Jan 17, 2020
Fixed compatibility issues with xtermjs 4
0e3b4f3 
xtermjs 4 removed the on() listener method and
replaced it with onData, onResize, ... methods

related wavesoft#11
@kaorimatz kaorimatz mentioned this issue May 29, 2020
Open
@ZanzyTHEbar
Copy link

Xterm now broken again, new Xterm API does not have .on method.

@tjhowse
Copy link

tjhowse commented Aug 13, 2022

@ZanzyTHEbar
This issue was fixed in 5bbd5b8 however this code hasn't found its way into a release yet, as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wavesoft @tjhowse @mattLLVW @ZanzyTHEbar