Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] gh: Incorrect windows ARCH parsing #941

Open
pyhedgehog opened this issue Dec 24, 2024 · 1 comment
Open

[Bug] gh: Incorrect windows ARCH parsing #941

pyhedgehog opened this issue Dec 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@pyhedgehog
Copy link

Description

On windows gh.tab you can see that both gh_*_windows_386.msi and gh_*_windows_amd64.msi has ARCH=amd64.

Expected

It's expected that *_386.* marked as x86.

Proposal

webi-installers/_webi/normalize.js

Line 60 in 9766022

x86: /(\b|_|amd|(dar)?win(dows)?|mac(os)?|linux|osx|x)(86|32)([_\-]?bit)(\b|_)/i,

Here regexp should be changed to:
/(\b|_|amd|(dar)?win(dows)?|mac(os)?|linux|osx|x)(86|32|386)([_\-]?bit)?(\b|_)/i.
@pyhedgehog pyhedgehog added the bug Something isn't working label Dec 24, 2024
pyhedgehog added a commit to pyhedgehog/webi-installers that referenced this issue Dec 24, 2024
@pyhedgehog
Fixes webinstallGH-941
da5c96d
@coolaj86
Copy link
Member

Thanks for the report and the fix. I'll update this tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coolaj86 @pyhedgehog