Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huggingface download stats incorrect due to change in download method #896

Open
ethanwhite opened this issue Jan 22, 2025 · 0 comments
Open
Assignees

Comments

@ethanwhite
Copy link
Member

The huggingface download stats are almost certainly too low (they currently show 13 downloads in the last month of the tree model. I suspect this is due to our change from a custom download system to the built-in .from_pretrained() combined with our attempts to track downloads.

We submitted code to model-libraries.ts that sets the tracking to occur when .pt and .pl files are downloaded:

But from_pretained is downloading .safetensors and (I believe) config.json.

So, I suspect this will all 'just work' if we remove the custom code from model-libraries.ts. Alternatively we could change the extensions to .json and .safetensors, but it feels like the default implementation is best if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants