Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with timeouts for unreliable backends #221

Closed
edsko opened this issue Oct 17, 2024 · 1 comment
Closed

Deal with timeouts for unreliable backends #221

edsko opened this issue Oct 17, 2024 · 1 comment
Assignees
Labels
priority: medium Should be done before the library can be considered complete

Comments

@edsko
Copy link
Collaborator

edsko commented Oct 17, 2024

The Deadlines guide states:

Deadline on the client

(..)

If a server has gone past the deadline when processing a request, the client will give up and fail the RPC with the DEADLINE_EXCEEDED status.

We don't currently do this (we rely on the server to respect grpc-timeout).

The timeout should apply even when wait-for-ready is enabled, see https://grpc.io/docs/guides/wait-for-ready/ .

@edsko edsko added the priority: medium Should be done before the library can be considered complete label Oct 17, 2024
@edsko
Copy link
Collaborator Author

edsko commented Jan 17, 2025

See also discussion of timeout_on_sleeping_server in interop.md; we might need to update that once this is fixed.

@edsko edsko self-assigned this Jan 17, 2025
edsko added a commit that referenced this issue Jan 17, 2025
edsko added a commit that referenced this issue Jan 17, 2025
@edsko edsko closed this as completed in ba7d442 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Should be done before the library can be considered complete
Projects
None yet
Development

No branches or pull requests

1 participant