-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Closure for 'AsseticBundle\Configuration' and create a factory class instead #166
Comments
I will gladly accept PR with Factory :) |
Dear Widmogrod, I have just submitted PR #167 Regards, |
Great job! |
I released version 2.2.0 |
You are welcome ! Thanks for this module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The use of the Closure for 'getServiceConfig' in Module.php
public function getServiceConfig() { return array( 'factories' => array( 'AsseticBundle\Configuration' => function (ServiceLocatorInterface $serviceLocator) { $configuration = $serviceLocator->get('Configuration'); return new Configuration($configuration['assetic_configuration']); } ), ); }
prevents the use of caching configuration in zf (https://framework.zend.com/manual/2.4/en/tutorials/config.advanced.html)
has Closures can't be serialized
Would it be possible to have instead a Factory in your module ?
Thank you in advance
The text was updated successfully, but these errors were encountered: