Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for "switching" default host/profile for managed domain #36

Open
Ladicek opened this issue Dec 12, 2015 · 0 comments
Open

support for "switching" default host/profile for managed domain #36

Ladicek opened this issue Dec 12, 2015 · 0 comments
Assignees

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Dec 12, 2015

Currently, when creating Online|OfflineOptions for managed domain, one can specify a default host and/or default profile. This choice is then set in stone, which forces users to either completely avoid the convenience of transforming standalone operations to domain, or to create separate clients for each host/profile. Both options are unfriendly, the second additionally causes more overhead.

The API could be reworked a bit to address the issue. The default host/profile wouldn't be set in the Online|OfflineOptions. Instead, one would be able to create a host- and/or profile-specific Online|OfflineManagementClient from the "default" one by calling .forProfile or .forHost. These specific clients would delegate to the original management client and only perform the transformation.

If possible, this should be backwards-compatible. That's hard, though, because the default host and profile is currently publicly accessible from Online|OfflineOptions.

Thanks to @akostadinov for the basic idea of using a wrapper!

@Ladicek Ladicek self-assigned this Dec 12, 2015
@Ladicek Ladicek modified the milestone: 1.0.0 Dec 12, 2015
olukas pushed a commit to olukas/creaper that referenced this issue Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant