Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge draw_text into draw_label #77

Open
tbates opened this issue Oct 10, 2017 · 1 comment
Open

merge draw_text into draw_label #77

tbates opened this issue Oct 10, 2017 · 1 comment

Comments

@tbates
Copy link
Contributor

tbates commented Oct 10, 2017

Instead of maintaining draw_text and draw_label, it would be nice to just allow the (more capable) draw_label to take vectors of text, x, and y, check the lengths match, and call itself to execute each in turn.

One might then deprecate draw_text

@clauswilke
Copy link
Contributor

A few comments:

  1. In principle, I agree that having two separate functions is not desirable.

  2. I'm happy to consider a pull request.

  3. It would have to be verified that the more capable draw_text behaves exactly like the old one for regular text input. A lot of code is out there in the world using draw_text, and people shouldn't have to update all their figure-drawing code because of a minor improvement in the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants