You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the encryption of {} in the case of a server island with no props. Fixes#12949.
Testing
Added two tests: one test that ensures components with props keep getting them re-encrypted, and one where components without props don't have an empty encryption passed through to them.
Docs
Nominally a bugfix, brings the docs mention of caching in line with reality.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
@kaytwo your tests are failing, because fixture.fetch() doesn't work without a runnign server. Those tests will work in dev but not prod. Take a look at how the other dev and prod tests are implemented in that file. It would be good to have tests for both. You can run the tests locally by running node --test packages/astro/test/server-islands.test.js
pkg: astroRelated to the core `astro` package (scope)
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
pkg: astro
Changes
This change removes the encryption of
{}in the case of a server island with no props. Fixes #12949.Testing
Added two tests: one test that ensures components with props keep getting them re-encrypted, and one where components without props don't have an empty encryption passed through to them.
Docs
Nominally a bugfix, brings the docs mention of caching in line with reality.