Render uniform WP time picker over default time input element #489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Have you written new tests for your changes, as applicable?Not applicableWill this change require new documentation or changes to existing documentation?Documentation for this change would live on the WooCommerce Bookings side if neededChanges proposed in this Pull Request:
wc-bookings-render-wp-time-picker
class to the time input on the Bookings -> Settings -> Accommodations admin menu to render a uniform time selector that follows sitewide time formatsCloses #364.
Steps to test the changes in this Pull Request:
Warning
**‼️ ‼️ NOTE - BLOCKED by WC BOOKINGS PR 3926: This change relies on code introduced in https://github.com/woocommerce/woocommerce-bookings/pull/3926.
Note
There is no chance of introducing bugs if this PR is merged first.
Without the WooCommerce Bookings PR there will be no change whatsoever in appearance or functionality of the input time selector. The only code change in this PR is adding the class that the JS uses to select and initialize the time picker.**
/wp-admin/edit.php?post_type=wc_booking&page=wc_bookings_settings&tab=accommodation
/wp-admin/edit.php?post_type=wc_booking&page=wc_bookings_settings&tab=accommodation
should adapt to display the 12 hour formatFunctionality - Admin
Functionality - FE
/wp-admin/edit.php?post_type=wc_booking&page=wc_bookings_settings&tab=accommodation
Changelog entry