Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart #1

Open
3 of 4 tasks
lizkaraffa opened this issue Jun 28, 2017 · 3 comments
Open
3 of 4 tasks

Cart #1

lizkaraffa opened this issue Jun 28, 2017 · 3 comments

Comments

@lizkaraffa
Copy link
Collaborator

lizkaraffa commented Jun 28, 2017

Loves:

  • Simplicity
  • slide-out cart on all breakpoints

Opportunities:

  • Circle buttons add, subtract, remove and edit feel small and too close on mobile, seems like there is a good chance that the wrong button could get pressed, could stand to be a bit bigger on all screen sizes in my opinion
  • Would like a little hover interaction with the buttons to know for sure that they are buttons
  • Just because of math context, when I saw these circle buttons ( + ) ( - ) ( x ) next to each other I immediately though add, subtract, multiply...and was like multiply? who multiplies product? Then I thought some more, and was like "oh wait...haha remove...duh" Maybe swapping the pencil and x positions might have more clarity that x is to remove. Or I could be crazy and a one-offer.

[update]

  • Have product titles be links to their product page.

Clarification:

  • What happens when you click on the edit icon. What becomes editable, what is the expected functionality and how does that look?
@jptksc
Copy link
Collaborator

jptksc commented Jun 28, 2017

@lizkaraffa Thumbs up on all the opportunity points you've made. I'll update those as I have time next week. Regarding the clarification point, my thought with the edit button was that it would load the product page again so you could choose a different color/size/etc. Is that a valid thought? or should we ditch that button all together?

@lizkaraffa
Copy link
Collaborator Author

@Circa75 regarding the pencil button. Hmm I could see it be awesome or redundant since normally you can click on the product title to go back to the product page. Just realizing the title is not linked up, that'd probably be good to add. Also, functionality might be tricky for the pencil icon, because if you go back to the product page and change variations etc and then click add to cart, it's going to add a new product to your cart and not "edit" the one you already had in there. Maybe if there was an elegant way to change variations while still in the cart? Otherwise it could get ditched.

@jptksc
Copy link
Collaborator

jptksc commented Jun 30, 2017

Sounds good... I'll think that one over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants