Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use HMR API for dev server communication #1361

Closed
wants to merge 6 commits into from
Closed

fix: Use HMR API for dev server communication #1361

wants to merge 6 commits into from
+156 −243

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Jan 21, 2025 •
edited
Loading

This closes #1360

@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 51a16fe
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67907b276d67d0000864a667
😎 Deploy Preview https://deploy-preview-1361--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 21, 2025 •
edited
Loading

Open in Stackblitz

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1361

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1361

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1361

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1361

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1361

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1361

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1361

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1361

wxt

npm i https://pkg.pr.new/wxt@1361

commit: 51a16fe

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 81.77%. Comparing base (55a1f39) to head (bebb8c9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/wxt/src/virtual/background-entrypoint.ts 0.00% 13 Missing ⚠️
packages/wxt/src/virtual/reload-html.ts 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
+ Coverage   81.26%   81.77%   +0.50%     
==========================================
  Files         128      127       -1     
  Lines        6288     6238      -50     
  Branches     1069     1067       -2     
==========================================
- Hits         5110     5101       -9     
+ Misses       1163     1123      -40     
+ Partials       15       14       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 mentioned this pull request Jan 21, 2025
Open
5 tasks
@aklinker1
Copy link
Collaborator Author

aklinker1 commented Jan 22, 2025 •
edited
Loading

I could only get this to work with ESM content scripts, not for the default IIFE background scripts. Gonna stick with use the websocket manually.

#1360 (comment)

@aklinker1 aklinker1 closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popup HTML auto refresh does not work with Vite 6.0.9+
1 participant
@aklinker1