You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The OpenTelemetry::Instrumentation::LogBackend logs asynchronously from a different fiber.
This prevents the logs from being attached to the span from which the log entry was produced.
To Reproduce
Configure the Log with OpenTelemetry::Instrumentation::LogBackend as the log backend.
Expected behavior
Logs emitted to OpenTelemetry::Instrumentation::LogBackend should be attached as events to the span that produced the Log::Entry
The text was updated successfully, but these errors were encountered:
I think the easiest fix here is to make the OpenTelemetry::Instrumentation::LogBackend only operate with a SyncDispatcher. The only thing that it is doing is adding an event to the existing span, so this should be extremely fast, which reduces any argument for an AsyncDispatcher. Also, if using the AsyncDispatcher, the code would have to ensure that the Span object itself still exists by the time that the LogBackend#write method ends up being called.
Describe the bug
The
OpenTelemetry::Instrumentation::LogBackend
logs asynchronously from a different fiber.This prevents the logs from being attached to the span from which the log entry was produced.
To Reproduce
Configure the
Log
withOpenTelemetry::Instrumentation::LogBackend
as the log backend.Expected behavior
Logs emitted to
OpenTelemetry::Instrumentation::LogBackend
should be attached as events to the span that produced theLog::Entry
The text was updated successfully, but these errors were encountered: