Skip to content
This repository has been archived by the owner on Dec 12, 2020. It is now read-only.

Downloader : Edit MP3 tags with accurate genres #98

Open
krthush opened this issue Oct 17, 2019 · 4 comments
Open

Downloader : Edit MP3 tags with accurate genres #98

krthush opened this issue Oct 17, 2019 · 4 comments

Comments

@krthush
Copy link

krthush commented Oct 17, 2019

I know this is likely a tricky one... since when you download through the monstercat website itself (at least for the 320kbps mp3s like I download) you only get a file with a genre of "electronic"

Now I know that the catalog itself (on the official monstercat page + the monsterutils tool) do know of the more specific genre for the songs (e.g. "Future Bass", "Nu Disco", etc.) Was wondering how hard something like this would be to implement - would make for a far more accurate/complete library which I think a lot of people would love!

I can imagine it could be hard since I assume you currently download through an API to monstercat, doing something like this may involve actually editing the file tags after the download.

@defvs
Copy link
Collaborator

defvs commented Oct 18, 2019

This already has been discussed on the discord; we could modify the MP3 tags on download with the MCatalog genres or the API genres, but dealing with MP3 tags is hard and we haven't figured it out yet.
We'll probably do it one day, but it isn't high priority for now.

@defvs defvs added the enhancement New feature label Oct 18, 2019
@defvs defvs changed the title Make downloads genre more specific? Not just "electronic" ? Downloader : Edit MP3 tags with accurate genres Oct 18, 2019
@defvs
Copy link
Collaborator

defvs commented Oct 18, 2019

This could be an interesting library. Allows for editing tags easily. http://javamusictag.sourceforge.net/

@xeruf
Copy link
Owner

xeruf commented Oct 18, 2019

This could be an interesting library. Allows for editing tags easily. http://javamusictag.sourceforge.net/

Looks interesting.

I have used http://www.jthink.net/jaudiotagger/ before and have already been thinking about implementing this feature with it, but never got around to it. More interesting to me would then be BPMs n stuff actually.

@defvs
Copy link
Collaborator

defvs commented Oct 18, 2019

I could try a few thing, but as you said we need to prioritize fixing bug first before implementing new features

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants