Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

All APIs stopped working #29

Open
Ben-Mark opened this issue Aug 11, 2020 · 1 comment
Open

All APIs stopped working #29

Ben-Mark opened this issue Aug 11, 2020 · 1 comment

Comments

@Ben-Mark
Copy link

Ben-Mark commented Aug 11, 2020

Hi, this amazing library which helped a lot of us download songs from youtube via song id
has stopped working

None of the methods work anymore

getInfo
filterFormats

even the main option for downloading a song

Please specify what needs to be maintained and I'll contribute a PR

Please advise,
Thanks,
Ben

@AbelTesfaye
Copy link
Collaborator

Hi Ben, Thanks for reporting, I've published the latest update.

Also thanks for your interest in contributing, Whenever I update the library I download the latest ytdl-core and run diff with the react-native version.
Then I carefully patch the changes that don't have anything to do with node's streaming api (this usually involves porting some node specific logic to its react-native equivalent).
Finally, I test all methods to make sure I didn't accidentally break anything.

If you'd like to give it a hand, try patching the 3.1.1 branch using diffs from the latest ytdl-core. Here are the changes I've introduced to the latest version. There were relatively fewer changes so I think it should somewhat give you an idea of how to patch future versions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants