Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OAuth Refresh Tokens #28

Open
hjacobs opened this issue Dec 15, 2016 · 4 comments
Open

Support OAuth Refresh Tokens #28

hjacobs opened this issue Dec 15, 2016 · 4 comments
Assignees
@gargravarr

Comments

@hjacobs
Copy link
Contributor

hjacobs commented Dec 15, 2016

We are using implicit flow with refresh tokens --- so support them.
@gargravarr
Copy link
Contributor

Use the provided refresh token to request a new access token, so a browser window is not opened.

@gargravarr gargravarr self-assigned this Dec 15, 2016
gargravarr added a commit that referenced this issue Dec 15, 2016
@gargravarr
#28 Added intial function te get token via redfresh token
349d3fe
gargravarr added a commit that referenced this issue Dec 15, 2016
@gargravarr
#28 finished development
46ca698
gargravarr added a commit that referenced this issue Dec 15, 2016
@gargravarr
#28 removed unnecessary var
a234aab
gargravarr added a commit that referenced this issue Dec 15, 2016
@gargravarr
#28 added timeout. fixed raise for status
1c3fb8d
gargravarr added a commit that referenced this issue Dec 15, 2016
@gargravarr
#28 moved refresh token to a separate file
78f745d
gargravarr added a commit that referenced this issue Dec 15, 2016
@gargravarr
#28 removed duplicated code
f7745fc
gargravarr added a commit that referenced this issue Dec 15, 2016
@gargravarr
#28 removed even more duplicated code
dcaed0d
@hjacobs
Copy link
Contributor Author

hjacobs commented Dec 15, 2016

TODO: manage multiple refresh tokens. @sarnowski proposed to save both the access_token and refresh_token both in tokens.yaml. I think that makes sense.

gargravarr added a commit that referenced this issue Dec 15, 2016
@gargravarr
#28 Fixed config file save
e229793
gargravarr added a commit that referenced this issue Dec 15, 2016
@gargravarr
Merge pull request #35 from zalando-stups/28-fix-config-file-save
b95d15b 
#28 Fixed config file save
@gargravarr
Copy link
Contributor

@hjacobs @sarnowski refresh tokens are already saved in tokens.yaml

@hjacobs
Copy link
Contributor Author

hjacobs commented Dec 15, 2016

@gargravarr yes, but we need to use the refresh_token in tokens.yaml to support different scopes per token.

@hjacobs hjacobs reopened this Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gargravarr gargravarr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbellmann @hjacobs @gargravarr