From b8eaaac045718d7be6119affb048caa9822b297b Mon Sep 17 00:00:00 2001 From: Austin Abro Date: Mon, 30 Sep 2024 20:30:10 +0000 Subject: [PATCH] comment Signed-off-by: Austin Abro --- src/internal/packager/helm/chart.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/internal/packager/helm/chart.go b/src/internal/packager/helm/chart.go index 3e45465944..1f9fb9a8f0 100644 --- a/src/internal/packager/helm/chart.go +++ b/src/internal/packager/helm/chart.go @@ -137,6 +137,10 @@ func (h *Helm) InstallOrUpgradeChart(ctx context.Context) (types.ConnectStrings, }) } if !h.chart.NoWait { + // This effectively doubles the amount of time a timeout can take + // 15 minute timeout -> 14 minutes to install -> another 14 minutes of waiting + // This could be avoided by creating the context in the start of the retry loop + // Technically would be a breaking change, in practice this is unlikely to affect anyone healthChecksCtx, cancel := context.WithTimeout(ctx, h.timeout) defer cancel() spinner.Updatef("Running health checks")