Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review test-stat* and test-theme #1

Open
zeehio opened this issue Nov 7, 2017 · 0 comments
Open

Review test-stat* and test-theme #1

zeehio opened this issue Nov 7, 2017 · 0 comments

Comments

@zeehio
Copy link
Owner

zeehio commented Nov 7, 2017

  • I added all the ggplot tests from 2.2.1
  • I reviewed the tests, removing those testing ggplot internals
  • I simplified the tests, testing only for equality between ggplot objects generated by ggpipe and ggplot (the plot building phase is not touched by ggpipe)

The last step (simplify the tests) was not done for the test-stat* and test-theme* tests, so I leave that for the future, before a CRAN release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zeehio