Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve viewing of the definitions #19

Open
poeti8 opened this issue Aug 6, 2022 · 1 comment
Open

Improve viewing of the definitions #19

poeti8 opened this issue Aug 6, 2022 · 1 comment

Comments

@poeti8
Copy link

poeti8 commented Aug 6, 2022

First of all, I really like the idea, congrats on that.

One thing that makes it a bit inconvenient for me to use is that it's almost hard to focus on the definitions while the section is that small and keyboard is always open. Most of the time you even need to scroll there to see more context on the word. I think it's nice to have an overview of the word and see more parts of the definitions with one look rather than being needed to scroll.

A few improvements that come to my mind are:

  • Make the definitions section bigger.
  • Add the ability to close the keyboard. I'm on iOS and this is currently not possible.
  • Have some sort of "view mode", where you tap on the words and you only see the definitions without keyboard being opened. Or, respectively, there could be an edit button where the default mode would be viewing the words and you'd only add or edit words once you're on edit mode.

Let me know what you think. I haven't worked with react-native that much before, but if you need so I'd be happy to contribute if I can.

@poeti8 poeti8 changed the title Improve viewing the definitions Improve viewing of the definitions Aug 6, 2022
@TDHTTTT
Copy link

TDHTTTT commented Aug 20, 2022

@poeti8 could you try my #21 and see if it at least addresses the first 2 improvements you mentioned? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants