-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made Bitcoin user aware if a deposit is not observe because of deposit fee #3193
Comments
I don't think creating a CCTX just to show the error message is a good idea
|
Here is a draft PR that registers an aborted CCTX for failed inbounds due to insufficient fee: #3358 Considering the team might have other considerations, it is open for discussions. So, in order to allow the users to track the status of a failed inbound, we need to record a status for each If on-chain: the error will be written to Zetachain or Bitcoin. If off-chain: the error will be written to some database/server/indexer and queries needs to be publicly available to users. I think @fadeev could also share some insights from developer experience perspective. |
I understand the concerns @kingpinXD outlined, but having this on-chain is still preferable compared to an off-chain solution with a database. Alternatively, we write a client-side function that can definitively tell if a specific tx has been processed or rejected due to deposit fees. |
We have 9 |
I see your point; however, even if there are 9 individual DBSs, there might be inconsistency between them. Would that be an option for exploitation? |
Yeah. The data inconsistency, lacking persistency and public access availability are the concerns. Usually, triggering a failed inbound (less deposit fee) in Bitcoin is more expensive than a triggering a successful inbound on other chains. Example Bitcoin inbound ($1.31): https://mempool.space/tx/7877075d50e645b76d4fb402699cac6e992ce8f88c506b47c94039baa1c40023 |
Yeah that's true
I do think having the cctx is the best for user experience, but we should exhaust all other options before finalizing this |
Describe the Issue
A user should be aware if a deposit can't be processed because of depositFee
Eventually it is addressed in the toolkit https://github.com/zeta-chain/toolkit, prevent doing deposit less than the deposit fee
The text was updated successfully, but these errors were encountered: