Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with choosing the duration of a test video clip during the testing phase #23

Open
xu-xh opened this issue Jan 2, 2025 · 2 comments

Comments

@xu-xh
Copy link

xu-xh commented Jan 2, 2025

Hi! Thanks for your work here. Why was the length of the real PPG signal captured during the test 30 seconds instead of a smaller value, 10s or 20s. wouldn't a smaller value mean a closer approximation to real time heart rate. Isn't this relationship the same as the difference between instantaneous rate and average rate?

@zhaodongsun
Copy link
Owner

Hi, you can choose other lengths for test. 30s is just a default value used in most works. Smaller length is more close to instantaneous heart rate, but may also cause error due to small length.

@xu-xh
Copy link
Author

xu-xh commented Jan 7, 2025

Thanks. And what about the length of the frames and the image size of the model input? In fact, when I set the frame length of the model input to 128 and the image size to 96, your model predictions become much worse, especially on the PURE dataset. Can you please tell me how you compare your proposed contrast-phys+ method between many studies that are in different processing conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants