Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use trace id of external service #472

Closed
hifabienne opened this issue Nov 2, 2023 · 2 comments · Fixed by #564
Closed

use trace id of external service #472

hifabienne opened this issue Nov 2, 2023 · 2 comments · Fixed by #564
Assignees
Labels

Comments

@hifabienne
Copy link
Member

Describe your problem

The oidc lib currently always creates a root span even though my service already provides a trace id. I currently have to correlate the two traces manually which is error prone and maybe the call doesn't even get traced if the fraction does not match.

Describe your ideal solution

If my service uses tracing i want to be able provide this traceid to zitadel so that i can see the zitadel calls as sub spans.

@muhlemmer
Copy link
Collaborator

The issue here is that the utilities we need for the behavior you describe are in zitadel and therefore cannot be imported into oidc. Now that we have v3 in zitadel and we will implement all methods directly (deprecating the storage interface) the traces should get better in time.

If you think we need to improve this earlier, we will have to see if we can abstract or duplicate some of the trace code from zitade.

@hifabienne
Copy link
Member Author

hei @muhlemmer
Thanks for the feedback.
This issue was raised by a client who uses our oidc lib in their own application, where they also want to be able to set the trace ids

@hifabienne hifabienne moved this to 📨 Product Backlog in Product Management Nov 3, 2023
@muhlemmer muhlemmer moved this from 📨 Product Backlog to 🔖 Ready in Product Management Nov 7, 2023
@hifabienne hifabienne moved this from 🔖 Ready to 📋 Sprint Backlog in Product Management Feb 29, 2024
@adlerhurst adlerhurst moved this from 📋 Sprint Backlog to 🏗 In progress in Product Management Mar 6, 2024
@adlerhurst adlerhurst mentioned this issue Mar 6, 2024
13 tasks
@adlerhurst adlerhurst linked a pull request Mar 6, 2024 that will close this issue
13 tasks
@adlerhurst adlerhurst moved this from 🏗 In progress to 👀 In review in Product Management Mar 6, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Product Management Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants