Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language menu broken in multi-host setting #214

Open
dholbach opened this issue Dec 27, 2024 · 3 comments
Open

Language menu broken in multi-host setting #214

dholbach opened this issue Dec 27, 2024 · 3 comments

Comments

@dholbach
Copy link
Contributor

dholbach commented Dec 27, 2024

I'm a bit late to the party, as I was using an index.html with a small local diff in my set-up, but this PR appears to undo some parts of a43bb4e which seem to be needed in a multi-host setting.

Originally posted by @dholbach in #196 (comment)

@dholbach
Copy link
Contributor Author

Here is a small test case:

gh repo clone dholbach/scroll-multisite
cd scroll-multisite/
hugo server

Point your browser to http://localhost:1313.

@dholbach
Copy link
Contributor Author

dholbach commented Jan 8, 2025

cc @chatziko

Do you have an idea how we can make both use-cases work?

@dholbach
Copy link
Contributor Author

a43bb4e introduced a regression. What can we do to fix it?

The easiest work-around I can think of without having done too much research is to use {{ hugo.IsMultihost }} to detect what to do and have both old and new behaviour in an if / else switch, but maybe there's an easier way to reconcile both use-cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant