-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fonts supporting wider set of diacritics and accented characters #71
Comments
Hi @whizz, thank you for getting in touch 👍.
I agree 💯- Could you open a pr
please 🙏? Then, we can check how much of an increase in filesize this is. Maybe it's not that much 😇 If it seems too big, we'll go with
Sounds like a plan?
Thank you for the kind words. You have to thank Yonatan Wolowelsky for the original theme though. I just ported it from Ghost to Hugo 🤓😄. |
Apparently, Open Sans Condensed is no longer available at Google Fonts 🤦♂️ I'll have to figure out what to do about it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Lighthouse gives me this warning:
Could you add But the way, i 2nd this issue. I would like to have easy option to disable custom fonts |
@whizz This is also issue for me, you you have any specific fonts in mind? |
The change introduced #48, while generally a step in the right direction, unfortunately broke my non-latin site, because the local fonts are only in latin set, which does not contain some Czechs letters (such as ě,š,...) and I am sure many others from other languages.
I could submit a PR which would include the full font character set, but that would of course increase the size of the font files.
Alternatively, there could be some configuration setting to select the desired sets, but that will be quite complicated to do and use.
Or I can do that locally on my site, replacing the fonts.css with my own version and add the proper font files.
What do you think, @janraasch ? BTW: Thank you so much for creating the theme and sharing it with us.
The text was updated successfully, but these errors were encountered: