Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove blurry antialiasing #99

Closed
wants to merge 1 commit into from

Conversation

filiptdz
Copy link

@filiptdz filiptdz commented Dec 4, 2024

Fixes #98

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for zmk-studio ready!

Name Link
🔨 Latest commit a6f490f
🔍 Latest deploy log https://app.netlify.com/sites/zmk-studio/deploys/67504174b069810008ad9b5d
😎 Deploy Preview https://deploy-preview-99.preview.zmk.studio
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property was originally added to fix AA on rotated keys according to this: 899c355

I'm interested where you're seeing the blurriness from. I couldn't recreate it using the keymap zoom in the top right or by doing a cmd+ or pinching my fingers. I can recreate it in storybook using that zoom, but I'm not sure what it's doing?

@filiptdz
Copy link
Author

@Nicell thanks! yeah I saw the other commit, and figured there was a specific reason for it, although I couldn't find it. I'm curious whether there's another workaround for that.

I can see the blurriness on the https://zmk.studio website by setting the scale on the top right corner to 25%, reloading the page, and then setting it to 200%.

I saw it initially on the standalone MacOS application, by resizing the window. However, there even hovering a key with the mouse doesn't force it to re-render without being blurry, so I'm not sure if the fix would work the same way

@pongstr
Copy link

pongstr commented Dec 12, 2024

👋🏽 @filiptdz this PR #108 might interest you, it eliminates the blurring issue and improves the scale transition

@filiptdz
Copy link
Author

@pongstr that does solve the issue and looks extremely clean, I'll close my PR in favor of yours

thanks for bringing this to my attention 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

will-change: transform makes keyboard very blurry
3 participants