Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added .json to end of cache file name #12

Closed
wants to merge 2 commits into from
Closed

Conversation

0xStabby
Copy link

@0xStabby 0xStabby commented Jan 3, 2022

Fix to this issue: #11

@0xEnrico
Copy link
Owner

0xEnrico commented Jan 3, 2022

This pull request seems to me to get .json.cache and not .cache.json as it's needed by the CM.
Should be something like:

cache_filename = os.path.join('.json', os.path.join('.cache', args.env + "-" + args.cache_name))

to get the correct behaviour.
But let me have a quick look to support both new and old behaviour.

@0xEnrico
Copy link
Owner

0xEnrico commented Jan 3, 2022

Sorry, you are right, it's correct, but still, it would be nice to support both old and new filename. I'll have a look, should not be too difficult

@0xStabby 0xStabby closed this Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants