fix: l1infotreesync TestStressAndReorg #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rachit77
approved these changes
Oct 22, 2024
arnaubennassar
requested changes
Oct 25, 2024
| @@ -261,6 +261,8 @@ func TestWithReorgs(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestStressAndReorgs(t *testing.T) { | |||
| t.Skip() | |||
There was a problem hiding this comment.
I'm working on syncing the UpdateL1InfoTreeV2 event, which adds a sanity check on the expected root. This test makes the sanity check fail consistently...
I suspect that there is a problem with either the reorg detector, the processor or the integration of those.
Please do NOT merge this until I've figured this out... As I may end up finding the root of the problem 🤔
|
Closing this since the flaky test was fixed in: #182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing l1infotreesync TestStressAndReorg