test: e2e checking for multiples certificates submitted #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachit77
force-pushed
the
rachit77/CDK-598
branch
from
b00b65f to
832a21a
Compare
rachit77
requested review from
joanestebanr,
Stefan-Ethernal and
goran-ethernal
goran-ethernal
approved these changes
Dec 5, 2024
test/bats/pp/bridge-ci-e2e.bats
Outdated
| @@ -0,0 +1,100 @@ | |||
| setup() { | |||
There was a problem hiding this comment.
Why not expanding the existing one to send multiple deposits? Or even better to somehow parameterize how many of deposits we want to make?
So the optimal approach for me is to keep only the bridge-e2e.bats and either change the existing Native gas token deposit to WETH test to perform multiple deposits, or parameterize that test with deposits count (so that we can provide only single deposit in case we want to debug it for example). WDYT?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task: https://polygon.atlassian.net/browse/CDK-598