Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Allow either the 1.x or 2.x branch of composer installers #53

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

johnpbloch
Copy link
Contributor

Description of the Change

This change adds the 2.x branch to the versions that will satisfy the composer installers dependency. wpackagist already does this. Currently this plugin is blocking my ability to upgrade the installers package.

Alternate Designs

N/A

Benefits

The ability to update application code.

Possible Drawbacks

None.

Verification Process

composer update still works.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Regarding the last checkpoint: updating the tests to run on modern versions of PHP is something that would be worthwhile in the future, but is out of scope for this PR. This change does not make any changes that affect the PHP behavior of this plugin, so it should not be a concern regarding this PR specifically that I was unable to run the test suite.

Applicable Issues

N/A

Changelog Entry

N/A

@jeffpaul jeffpaul requested a review from tlovett1 December 7, 2021 23:00
@jeffpaul jeffpaul added this to the 4.2.0 milestone Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants